CA-407687/XSI-1834: get_subject_information_from_identifier should #6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changlei-li
reviewed
Mar 7, 2025
psafont
reviewed
Mar 7, 2025
lindig
approved these changes
Mar 7, 2025
|
Is there a danger that the information in xapi DB is outdated and we should have queried the AD but don't? How is the xapi DB kept up to date? |
There is a background task to update such info default in 10 minutes. This commit only affect the |
liulinC
force-pushed
the
private/linl/test-auth
branch
2 times, most recently
from
4947aa2 to
1a9159e
Compare
changlei-li
reviewed
Mar 10, 2025
changlei-li
approved these changes
Mar 10, 2025
liulinC
force-pushed
the
private/linl/test-auth
branch
from
1a9159e to
91bc80d
Compare
query xapi db, then fallback to query domain DC get_subject_information_from_identifier query subject details from subject id. It triggers some DNS query to do kerberos query. The subject details are actually cached in xapi db and refreshed default in every 10 minutes. get_subject_information_from_identifier should query subject details from xapi DB and only fallback to DC when xapi DB does not have it. Signed-off-by: Lin Liu <Lin.Liu01@cloud.com>
liulinC
force-pushed
the
private/linl/test-auth
branch
from
91bc80d to
76b46f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
query xapi db, then fallback to query domain DC
get_subject_information_from_identifier query subject details from subject id. It triggers some DNS query to do kerberos query, this causes the problem that authenticating to XAPI with an AD account causes large amounts of Kerberos / DNS traffic
The subject details are actually cached in xapi db and refreshed default in every 10 minutes. get_subject_information_from_identifier should query subject details from xapi DB and only fallback to DC when xapi DB does not have it.